linux-kernel - Re: [PATCH v2] staging: most: fix line ending with '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBvSQxgiFffWsoef@ubun2204.myguest.virtualbox.org>
Date:   Thu, 23 Mar 2023 09:44:59 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Khadija Kamran <kamrankhadijadj@...il.com>,
        outreachy@...ts.linux.dev,
        Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
        Christian Gromm <christian.gromm@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v2] staging: most: fix line ending with '('

On Wed, Mar 22, 2023 at 08:12:23AM -0700, Randy Dunlap wrote:
> Hi--
> 
> And FTR, I still haven't found anything in coding-style.rst that says that
> lines should not end with an open parenthesis.  Did I overlook it?

Hi Randy,
You are correct. I did not find anything clear or obvious that calls out not
ending the lines with a '(' symbol. 
I think the other guideline from the coding style is to align the overrunning
argument list in the next lines such that they match the arg1 after '('. So, I
think that may be the reason why checkpatch is coded to catch such lines.

Regards,
Deepak.

> 
> Thanks.