linux-kernel - Re: [PATCH] staging: vme_user: Fixing coding style issues reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBvbufoYo/wPp4qY@kroah.com>
Date:   Thu, 23 Mar 2023 05:55:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rohit Chavan <roheetchavan@...il.com>
Cc:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: Fixing coding style issues reported
 by checkpatch

On Wed, Mar 22, 2023 at 07:59:23PM +0530, Rohit Chavan wrote:
> Fixing alignment should match open parenthesis issue on multiple lines,
> reported by checkpatch script.

You might want to mention on the subject line that this is a parenthesis
issue, right?

> Signed-off-by: Rohit Chavan <roheetchavan@...il.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.c | 102 +++++++++++++-------------
>  1 file changed, 51 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 2f5eafd50934..716de1d7fe21 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -55,14 +55,14 @@ static struct pci_driver tsi148_driver = {
>  };
> 
>  static void reg_join(unsigned int high, unsigned int low,
> -	unsigned long long *variable)
> +		     unsigned long long *variable)

For many of these, you can just move the line to the previous one,
making it a single line, right?  That would make the code much more
readable.

thanks,

greg k-h