linux-kernel - RE: [PATCH -next] PCI: imx6: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AS8PR04MB86768249326301DE16AB36B08C879@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Thu, 23 Mar 2023 08:24:22 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "kw@...ux.com" <kw@...ux.com>, "robh@...nel.org" <robh@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] PCI: imx6: Use
 devm_platform_get_and_ioremap_resource()

> -----Original Message-----
> From: Yang Li <yang.lee@...ux.alibaba.com>
> Sent: 2023年3月23日 15:46
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; shawnguo@...nel.org; s.hauer@...gutronix.de;
> lpieralisi@...nel.org; kw@...ux.com; robh@...nel.org; bhelgaas@...gle.com;
> linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; Yang Li <yang.lee@...ux.alibaba.com>
> Subject: [PATCH -next] PCI: imx6: Use
> devm_platform_get_and_ioremap_resource()
> 
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to
> devm_platform_get_and_ioremap_resource(), as this is exactly what this function
> does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
Thanks.
Reviewed-by: Richard Zhu <hongxing.zhu@....com>

Best Regards
Richard Zhu

> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 55a0405b921d..c61c85e09c4b 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1259,8 +1259,7 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
>  			return PTR_ERR(imx6_pcie->phy_base);
>  	}
> 
> -	dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	pci->dbi_base = devm_ioremap_resource(dev, dbi_base);
> +	pci->dbi_base = devm_platform_get_and_ioremap_resource(pdev, 0,
> +&dbi_base);
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> 
> --
> 2.20.1.7.g153144c