linux-kernel - Re: [PATCH v3 2/6] mfd: Add support for the Lantiq PEF2256 framer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230323093154.5852f81b@bootlin.com>
Date:   Thu, 23 Mar 2023 09:31:54 +0100
From:   Herve Codina <herve.codina@...tlin.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v3 2/6] mfd: Add support for the Lantiq PEF2256 framer

On Thu, 23 Mar 2023 08:30:39 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 22/03/2023 14:46, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> > 
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>  
> 
> 
> > +static const struct of_device_id pef2256_id_table[] = {
> > +	{ .compatible = "lantiq,pef2256" },
> > +	{} /* sentinel */
> > +};
> > +MODULE_DEVICE_TABLE(of, pef2256_id_table);
> > +
> > +static struct platform_driver pef2256_driver = {
> > +	.driver = {
> > +		.name = "lantiq-pef2256",
> > +		.of_match_table = of_match_ptr(pef2256_id_table),  
> 
> Drop of_match_ptr. This will case warnings with W=1 and !OF.
> 
> Best regards,
> Krzysztof
> 

Acked. Will be dropped in v4.

Thanks.
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com