linux-kernel - [PATCH V2] rtc: k3: handle errors while enabling wake irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2023 14:29:04 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Vibhore Vardhan <vibhore@...com>, Dhruva Gole <d-gole@...com>,
        <linux-rtc@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        <linux-kernel@...r.kernel.org>, Nishanth Menon <nm@...com>
Subject: [PATCH V2] rtc: k3: handle errors while enabling wake irq

Due to the potential failure of enable_irq_wake(), it would be better to
return error if it fails.

Fixes: b09d633575e5 ("rtc: Introduce ti-k3-rtc")
Cc: Nishanth Menon <nm@...com>
Signed-off-by: Dhruva Gole <d-gole@...com>
---

Changelog:
Address the comments from Alexandre Belloni

V1 link:
https://lore.kernel.org/linux-rtc/20230323081942.951542-1-d-gole@ti.com

 drivers/rtc/rtc-ti-k3.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-ti-k3.c b/drivers/rtc/rtc-ti-k3.c
index ba23163cc042..0d90fe923355 100644
--- a/drivers/rtc/rtc-ti-k3.c
+++ b/drivers/rtc/rtc-ti-k3.c
@@ -632,7 +632,8 @@ static int __maybe_unused ti_k3_rtc_suspend(struct device *dev)
 	struct ti_k3_rtc *priv = dev_get_drvdata(dev);
 
 	if (device_may_wakeup(dev))
-		enable_irq_wake(priv->irq);
+		return enable_irq_wake(priv->irq);
+
 	return 0;
 }
 
-- 
2.25.1