linux-kernel - Re: [PATCH v6 19/21] riscv: dts: starfive: Add initial StarFive JH7110 device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ce5b897-f1c2-4b58-9353-9d9e881ad237@spud>
Date:   Thu, 23 Mar 2023 09:03:23 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Conor Dooley <conor@...nel.org>, <hal.feng@...rfivetech.com>
CC:     Hal Feng <hal.feng@...rfivetech.com>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Ben Dooks <ben.dooks@...ive.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 19/21] riscv: dts: starfive: Add initial StarFive
 JH7110 device tree

On Wed, Mar 22, 2023 at 10:02:40PM +0000, Conor Dooley wrote:
> On Mon, Mar 20, 2023 at 06:37:48PM +0800, Hal Feng wrote:
> > From: Emil Renner Berthing <kernel@...il.dk>
> > 
> > Add initial device tree for the JH7110 RISC-V SoC by StarFive
> > Technology Ltd.
> > 
> > Tested-by: Tommaso Merciai <tomm.merciai@...il.com>
> > Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> > Signed-off-by: Emil Renner Berthing <kernel@...il.dk>
> > Co-developed-by: Jianlong Huang <jianlong.huang@...rfivetech.com>
> > Signed-off-by: Jianlong Huang <jianlong.huang@...rfivetech.com>
> > Co-developed-by: Hal Feng <hal.feng@...rfivetech.com>
> > Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
> > ---
> 
> > +		S7_0: cpu@0 {
> > +			compatible = "sifive,s7", "riscv";
> > +			reg = <0>;
> > +			d-cache-block-size = <64>;
> > +			d-cache-sets = <64>;
> > +			d-cache-size = <8192>;
> > +			d-tlb-sets = <1>;
> > +			d-tlb-size = <40>;
> > +			device_type = "cpu";
> > +			i-cache-block-size = <64>;
> > +			i-cache-sets = <64>;
> > +			i-cache-size = <16384>;
> > +			i-tlb-sets = <1>;
> > +			i-tlb-size = <40>;
> > +			mmu-type = "riscv,sv39";
> > +			next-level-cache = <&ccache>;
> > +			riscv,isa = "rv64imac_zba_zbb";
> > +			tlb-split;
> > +			status = "disabled";
> 
> Jess pointed out on IRC that this S7 entry looks wrong as it is claiming
> that the S7 has an mmu. I didn't go looking back in the history of
> u74-mc core complex manuals, but the latest version does not show an mmu
> for the S7.

BTW Hal, if the dt-binding stuff is okay with Emil, I can just remove
the mmu here if you confirm it is a mistake rather than you needing to
resubmit to remove it.

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)