linux-kernel - Re: [PATCH 1/2] media: mediatek: vcodec: Remove decoder 'dma-ranges' conditon when set dma mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2023 09:13:09 +0000
From:   Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To:     "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
        "yong.wu@...iatek.org" <yong.wu@...iatek.org>,
        "wenst@...omium.org" <wenst@...omium.org>,
        Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "frkoenig@...omium.org" <frkoenig@...omium.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH 1/2] media: mediatek: vcodec: Remove decoder 'dma-ranges'
 conditon when set dma mask

On Thu, 2023-03-23 at 09:50 +0100, AngeloGioacchino Del Regno wrote:
> Il 23/03/23 09:38, Yunfei Dong ha scritto:
> > After commit f1ad5338a4d5("of: Fix "dma-ranges" handling for bus
> > controllers"),
> > the dma-ranges is not allowed in decoder dts node. But the driver
> > still need
> > to set dma mask, remove "dma-ranges" condition in prob function.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
> > ---
> > Reference series:
> > [1]: v5 of this series is present by Yong Wu.
> >       20230307023507.13306-1-yong.wu@...iatek.com
> > ---
> >   .../mediatek/vcodec/mtk_vcodec_dec_drv.c      | 24 +++++++++++++-
> > -----
> >   1 file changed, 17 insertions(+), 7 deletions(-)
> > 
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> > index bba7b932f4fa..2c3a4c2cdaee 100644
> > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> > @@ -137,6 +137,20 @@ static int
> > mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
> >       return 0;
> >   }
> > 
> > +static int mtk_vcodec_dec_set_dma_mask(struct device *dev)
> > +{
> > +     int ret = 0;
> > +
> > +     return !(of_device_is_compatible(dev->of_node,
> > "mediatek,mt8173-vcodec-dec") ||
> > +            of_device_is_compatible(dev->of_node,
> > "mediatek,mt8183-vcodec-dec"));
> 
> Like that, you're never reaching the code below...
> 
> Anyway, at a first glance, it looked like you were sending the same
> commit twice,
> but then I noticed... so... I would propose to change the commit
> title(s) to follow
> this format:
> 
> media: mediatek: vcodec: enc: Set DMA mask only for MT8173 and MT8183
> 
> (but then, why mt8173/83 and not the others? this deserves an
> explanation...)

This should be mt8173/83 don't need this. After confirming with yunfei,
I will fix the "return" above and contain this two patches and a jpeg
fix patch into the patchset of "Adjust the dma-ranges for MTK IOMMU".
This issue was introduced by that one since I removed "dma-ranges" for
them. they should be a topic.

> 
> 
> Regards,
> Angelo
> 
>