linux-kernel - Re: [PATCH] ACPI: APEI: EINJ: warn on invalid argument when explicitly indicated by platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a850c66-65de-c98b-4779-b22624f943d8@linux.alibaba.com>
Date:   Thu, 23 Mar 2023 09:19:42 +0800
From:   Shuai Xue <xueshuai@...ux.alibaba.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Luck, Tony" <tony.luck@...el.com>
Cc:     "baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>,
        "benjamin.cheatham@....com" <benjamin.cheatham@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zhuo.song@...ux.alibaba.com" <zhuo.song@...ux.alibaba.com>
Subject: Re: [PATCH] ACPI: APEI: EINJ: warn on invalid argument when
 explicitly indicated by platform



On 2023/3/23 AM12:52, Rafael J. Wysocki wrote:
> On Wed, Mar 22, 2023 at 5:13 PM Luck, Tony <tony.luck@...el.com> wrote:
>>
>>> Fix to return -EINVAL in the __einj_error_inject() error handling case
>>> instead of -EBUSY, when explicitly indicated by the platform in the status
>>> of the completed operation.
>>
>> Needs a bit longer description on the use case based on follow up discussion.
>> Key information is the EINVAL is an indicator to the user that the parameters they
>> supplied cannot be used for injection.
> 
> Right.
> 
> So Shuai, please resend the patch with a more elaborate changelog.

Ok, I will do it later.

> 
>> But for the code:
>>
>> Reviewed-by: Tony Luck <tony.luck@...el.com>
> 
> And add the above tag to it when resending.

Got it.

Thank you.

Best Regards.
Shuai