linux-kernel - Re: [PATCH] accel/habanalabs: Remove redundant pci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13Xi+w6OiR=_6Lqu9LPBfpmr-0deLUMkqsXsjXD0iKqNg@mail.gmail.com>
Date:   Thu, 23 Mar 2023 12:33:41 +0200
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Cc:     Cai Huoqing <cai.huoqing@...ux.dev>,
        Tomer Tayar <ttayar@...ana.ai>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] accel/habanalabs: Remove redundant pci_clear_master

On Thu, Mar 23, 2023 at 12:29 PM Stanislaw Gruszka
<stanislaw.gruszka@...ux.intel.com> wrote:
>
> On Thu, Mar 23, 2023 at 04:35:49PM +0800, Cai Huoqing wrote:
> > Remove pci_clear_master to simplify the code,
> > the bus-mastering is also cleared in do_pci_disable_device,
> > like this:
> > ./drivers/pci/pci.c:2197
> > static void do_pci_disable_device(struct pci_dev *dev)
> > {
> >       u16 pci_command;
> >
> >       pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> >       if (pci_command & PCI_COMMAND_MASTER) {
> >               pci_command &= ~PCI_COMMAND_MASTER;
> >               pci_write_config_word(dev, PCI_COMMAND, pci_command);
> >       }
> >
> >       pcibios_disable_device(dev);
> > }.
> > And dev->is_busmaster is set to 0 in pci_disable_device.
> >
> > Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>
> LGTM
>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
>
Applied to -next
Thanks,
Oded