linux-kernel - Re: [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBwys8kLg7NLOk+K@duo.ucw.cz>
Date:   Thu, 23 Mar 2023 12:06:27 +0100
From:   Pavel Machek <pavel@....cz>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Alice Chen <alice_chen@...htek.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        ChiaEn Wu <chiaen_wu@...htek.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: rgb: mt6370: correct config name to select in
 LEDS_MT6370_RGB

Hi!

> Commit 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink
> type LED Indicator support") introduces the config LEDS_MT6370_RGB, which
> selects the non-existing config LINEAR_RANGE. As the driver includes
> linux/linear_range.h, it is a safe guess that the config actually intends
> to select LINEAR_RANGES, which provides the library implementation for the
> function prototypes defined in the linear_range header file.
> 
> Correct this naming confusion in the LEDS_MT6370_RGB config
> definition.

Looks good.

Acked-by: Pavel Machek <pavel@....cz>

Best regards,
								Pavel

> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
>  config LEDS_MT6370_RGB
>  	tristate "LED Support for MediaTek MT6370 PMIC"
>  	depends on MFD_MT6370
> -	select LINEAR_RANGE
> +	select LINEAR_RANGES
>  	help
>  	  Say Y here to enable support for MT6370_RGB LED device.
>  	  In MT6370, there are four channel current-sink LED drivers that

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)