[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBxFkFlR3c7zX4fi@smile.fi.intel.com>
Date: Thu, 23 Mar 2023 14:26:56 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Kees Cook <keescook@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Cezary Rojewski <cezary.rojewski@...el.com>,
linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.com>,
"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v1 2/3] lib/string_helpers: Change returned value of the
strreplace()
On Wed, Mar 22, 2023 at 09:51:22AM -0700, Kees Cook wrote:
> On Wed, Mar 22, 2023 at 04:12:05PM +0200, Andy Shevchenko wrote:
> > It's more useful to return the original string with strreplace(),
>
> I found the use of "original" confusing here and in the comments. This
> just returns arg 1, yes? i.e. it's not the original (unreplaced) string,
> but rather just the string itself.
Yes.
Okay, I will try my best as non-native speaker to fix that for v2. Meanwhile
I'm open ears for the better suggestions.
> I agree, though, that's much more useful than a pointer to the end of
> the string.
Thank you!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists