linux-kernel - RE: [PATCH v6 4/4] i2c: designware: Add doorbell support for Mendocino

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2023 13:32:01 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Jan Dąbroś <jsd@...ihalf.com>,
        Grzegorz Bernacki <gjb@...ihalf.com>,
        Mark Hasemeyer <markhas@...omium.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 4/4] i2c: designware: Add doorbell support for
 Mendocino

[Public]



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Thursday, March 23, 2023 08:06
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: Jan Dąbroś <jsd@...ihalf.com>; Grzegorz Bernacki
> <gjb@...ihalf.com>; Mark Hasemeyer <markhas@...omium.org>; Jarkko
> Nikula <jarkko.nikula@...ux.intel.com>; Mika Westerberg
> <mika.westerberg@...ux.intel.com>; linux-i2c@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v6 4/4] i2c: designware: Add doorbell support for
> Mendocino
> 
> On Wed, Mar 22, 2023 at 04:02:26PM -0500, Mario Limonciello wrote:
> > Mendocino and later platform don't use the platform feature mailbox for
> > communication for I2C arbitration, they rely upon ringing a doorbell.
> >
> > Detect the platform by the device ID of the root port and choose the
> > appropriate method.
> 
> ...
> 
> > -	ret = read_poll_timeout(psp_send_i2c_req_cezanne, status,
> > +	ret = read_poll_timeout(_psp_send_i2c_req, status,
> >  				(status != -EBUSY),
> 
> You can place it now in the above line, but up to you.
> 
> >  				PSP_I2C_REQ_RETRY_DELAY_US,
> >  				PSP_I2C_REQ_RETRY_CNT *
> PSP_I2C_REQ_RETRY_DELAY_US,
> 
> ...
> 
> > +	/* Cezanne uses platform mailbox, Mendocino and later use doorbell
> */
> > +	rdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0));
> > +	if (rdev->device == 0x1630)
> > +		_psp_send_i2c_req = psp_send_i2c_req_cezanne;
> > +	else
> > +		_psp_send_i2c_req = psp_send_i2c_req_mendocino;
> 
> Where is pci_dev_put()?

Missing, thanks for catching it!