lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZB3ZLFCgqYxekE6U@google.com>
Date:   Fri, 24 Mar 2023 10:09:00 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Peter Gonda <pgonda@...gle.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Roth <michael.roth@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Vishal Annapurve <vannapurve@...gle.com>,
        Ackerley Tng <ackerleytng@...gle.com>,
        Andrew Jones <andrew.jones@...ux.dev>
Subject: Re: [PATCH V6 1/7] KVM: selftests: sparsebit: add const where appropriate

I suggest this for the shortlog

  KVM: selftests: Make sparsebit structs const where appropriate

Three deep scopes are a net negative IMO.  Too much of the shortlog is consumed
by the scope, and very few patches are actually capable of such precision, i.e.
touch more than a single area.

On Tue, Jan 10, 2023, Peter Gonda wrote:
> From: Michael Roth <michael.roth@....com>
> 
> Subsequent patches will introduce an encryption bitmap in kvm_util that

protected memory, not encryption

> would be useful to allow tests to access in read-only fashion. This
> will be done via a const sparsebit*. To avoid warnings or the need to
> add casts everywhere, add const to the various sparsebit functions that
> are applicable for read-only usage of sparsebit.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ