linux-kernel - Re: [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <225945e3-2610-4fec-8ee5-5893d26641b4@spud>
Date:   Fri, 24 Mar 2023 19:05:34 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Hal Feng <hal.feng@...rfivetech.com>
Cc:     devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties
 of S7 core

On Fri, Mar 24, 2023 at 02:46:51PM +0800, Hal Feng wrote:
> The S7 core has no L1 data cache and MMU, so delete some
> related properties.
> 
> Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
> ---
> 
> Hi, Conor,
> 
> This is a correction for the S7 entry.

Again going off the latest version of the u74-mc core complex, this
looks to be correct, thanks.
I need to go read the Emil email from earier today, but I've
provisionally gone and put this on the riscv-jh7100_initial_dts branch
with a Fixes: tag.

Thanks,
Conor.

> This patch depends on patch [1].
> 
> [1] https://lore.kernel.org/all/20230320103750.60295-20-hal.feng@starfivetech.com/
> 
> ---
>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index d484ecdf93f7..4c5fdb905da8 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -20,21 +20,12 @@ cpus {
>  		S7_0: cpu@0 {
>  			compatible = "sifive,s7", "riscv";
>  			reg = <0>;
> -			d-cache-block-size = <64>;
> -			d-cache-sets = <64>;
> -			d-cache-size = <8192>;
> -			d-tlb-sets = <1>;
> -			d-tlb-size = <40>;
>  			device_type = "cpu";
>  			i-cache-block-size = <64>;
>  			i-cache-sets = <64>;
>  			i-cache-size = <16384>;
> -			i-tlb-sets = <1>;
> -			i-tlb-size = <40>;
> -			mmu-type = "riscv,sv39";
>  			next-level-cache = <&ccache>;
>  			riscv,isa = "rv64imac_zba_zbb";
> -			tlb-split;
>  			status = "disabled";
>  
>  			cpu0_intc: interrupt-controller {
> -- 
> 2.38.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)