linux-kernel - Re: [PATCH] scsi: be2iscsi: set some be_main.c variables storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Mar 2023 17:06:59 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     ketan.mukadam@...adcom.com, jejb@...ux.ibm.com,
        Tom Rix <trix@...hat.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: set some be_main.c variables storage-class-specifier to static

On Mon, 13 Mar 2023 20:51:57 -0400, Tom Rix wrote:

> smatch reports several warnings
> drivers/scsi/be2iscsi/be_main.c:148:1: warning:
>   symbol 'dev_attr_beiscsi_log_enable' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:158:1: warning:
>   symbol 'dev_attr_beiscsi_drvr_ver' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:159:1: warning:
>   symbol 'dev_attr_beiscsi_adapter_family' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:160:1: warning:
>   symbol 'dev_attr_beiscsi_fw_ver' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:161:1: warning:
>   symbol 'dev_attr_beiscsi_phys_port' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:162:1: warning:
>   symbol 'dev_attr_beiscsi_active_session_count' was not declared. Should it be static?
> drivers/scsi/be2iscsi/be_main.c:164:1: warning:
>   symbol 'dev_attr_beiscsi_free_session_count' was not declared. Should it be static ?
> 
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: be2iscsi: set some be_main.c variables storage-class-specifier to static
      https://git.kernel.org/mkp/scsi/c/1efbacd2b95a

-- 
Martin K. Petersen	Oracle Linux Engineering