linux-kernel - Re: [RESEND PATCH] staging: most: fix line ending with '(' in dim2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <641e21a1235f6_325e1f2949@iweiny-mobl.notmuch>
Date:   Fri, 24 Mar 2023 15:18:09 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        <outreachy@...ts.linux.dev>
CC:     Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
        "Christian Gromm" <christian.gromm@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in dim2

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  drivers/staging/most/dim2/hal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
>  		dim2_clear_ctr(ctr_addr);
>  }
>  
> -static void dim2_configure_channel(
> -	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> -	u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,

NIT: This introduces a long (> 80 char) line for not a great reason.
Since you are changing it anyway how about?

static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx,
				   u16 dbr_address, u16 hw_buffer_size,
				   u16 packet_length)

Ira

> +				   u16 hw_buffer_size, u16 packet_length)

>  {
>  	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
>  	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> -- 
> 2.34.1
> 
>