linux-kernel - Re: [PATCH v2] usb: dwc3: host: remove dead code in dwc3_host_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QX+MvO2e+36Eip37mxtiPjSJs2zfBhP+mjwk43SSYXsJw@mail.gmail.com>
Date:   Fri, 24 Mar 2023 13:19:29 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mingxuan Xiang <mx_xiang@...t.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        hust-os-kernel-patches@...glegroups.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

On Fri, Mar 24, 2023 at 1:17 PM Dan Carpenter <error27@...il.com> wrote:
>
> On Fri, Mar 24, 2023 at 09:46:40AM +0800, Dongliang Mu wrote:
> >
> > On 2023/3/23 23:40, Greg Kroah-Hartman wrote:
> > > On Thu, Mar 23, 2023 at 05:53:10PM +0800, Mingxuan Xiang wrote:
> > > > platform_get_irq() no longer returns 0, so there is no
> > > > need to check whether the return value is 0.
> > > How did you find this issue?
> > >
> > > How was it tested?
> >
> > Hi Greg,
> >
> > We found this issue by Smatch. Our team is trying fix some true bugs found
> > by Smatch, with the help of Dan.
>
> LOL.  What did I do to get thrown under the bus like this?

Oh, my apologies :). We are a team. We together would like to fix
kernel bugs and do some contribution.

>
> >
> > Since this is a dead code removal, we only do compilation testing.
> >
>
> Just v3 and mention in the commit message that the issue was found by
> Smatch and the warning message that Smatch prints.  Put under the ---
> cut off line that it has only been compile tested.
>
> Also we needed to send a v3 anyway to remove the {} curly braces.

Yes, I have asked Mingxuan to craft this v3 patch.

>
> regards,
> dan carpenter
>
> --
> You received this message because you are subscribed to the Google Groups "HUST OS Kernel Contribution" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to hust-os-kernel-patches+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/hust-os-kernel-patches/adcd6c67-cedf-4831-9a9d-53c3ee2ebb88%40kili.mountain.