[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230324062408.49217-1-ye.xingchen@zte.com.cn>
Date: Fri, 24 Mar 2023 06:24:08 +0000
From: ye xingchen <yexingchen116@...il.com>
To: mcgrof@...nel.org
Cc: akpm@...ux-foundation.org, chi.minghao@....com.cn,
hch@...radead.org, keescook@...omium.org, linmiaohe@...wei.com,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, vbabka@...e.cz, willy@...radead.org,
ye.xingchen@....com.cn, yzaikin@...gle.com
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file
>$ ./scripts/bloat-o-meter vmlinux.old vmlinux
>add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4)
>Function old new delta
>vm_compaction - 320 +320
>kcompactd_init 167 193 +26
>proc_dointvec_minmax_warn_RT_change 104 10 -94
>vm_table 2112 1856 -256
>Total: Before=19287558, After=19287554, chg -0.00%
>
>So I don't think we need to pause this move or others where are have savings.
>
>Minghao, can you fix the commit log, and explain how you are also saving
>4 bytes as per the above bloat-o-meter results?
$ ./scripts/bloat-o-meter vmlinux vmlinux.new
add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
Function old new delta
vm_compaction - 320 +320
kcompactd_init 180 210 +30
vm_table 2112 1856 -256
Total: Before=21104198, After=21104292, chg +0.00%
In my environment, kcompactd_init increases by 30 instead of 26.
And proc_dointvec_minmax_warn_RT_change No expansion.
minghao
Powered by blists - more mailing lists