linux-kernel - Re: [PATCH] thermal: amlogic: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19b78f85-141e-eab7-2f4f-a30db3f8fb7e@linaro.org>
Date:   Fri, 24 Mar 2023 11:11:41 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     ye.xingchen@....com.cn, glaroque@...libre.com
Cc:     rafael@...nel.org, daniel.lezcano@...aro.org, amitk@...nel.org,
        rui.zhang@...el.com, linux-pm@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe()

On 24/03/2023 03:20, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>
> ---
>   drivers/thermal/amlogic_thermal.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 4bf36386462f..3abc2dcef408 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
>   		return PTR_ERR(pdata->regmap);
> 
>   	pdata->clk = devm_clk_get(dev, NULL);
> -	if (IS_ERR(pdata->clk)) {
> -		if (PTR_ERR(pdata->clk) != -EPROBE_DEFER)
> -			dev_err(dev, "failed to get clock\n");
> -		return PTR_ERR(pdata->clk);
> -	}
> +	if (IS_ERR(pdata->clk))
> +		return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n");
> 
>   	pdata->sec_ao_map = syscon_regmap_lookup_by_phandle
>   		(pdev->dev.of_node, "amlogic,ao-secure");

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>