linux-kernel - Re: [PATCH RESEND v3] nbd_genl_status: null check for nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230324101624.mnbagb3jxshucawq@blackpad>
Date:   Fri, 24 Mar 2023 11:16:24 +0100
From:   Michal Koutný <mkoutny@...e.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Josef Bacik <josef@...icpanda.com>, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org,
        Navid Emamdoost <navid.emamdoost@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH RESEND v3] nbd_genl_status: null check for nla_nest_start

Thanks for the reply.

On Thu, Mar 23, 2023 at 04:51:17PM -0600, Jens Axboe <axboe@...nel.dk> wrote:
> So please don't mix CVEs into any of this, they don't matter one bit.

Do not shoot the messenger.

(But I'll refrain from that numeric reference to disincentivize such
trophy collecting.)

> Never have, and never will. What's important is how the bug can be
> triggered.

From my perspective it's pragmatic better-safe-than-sorry -- a proof may
be conceived that rules out any triggering condition, it's less work to
put the guard in though.

My .02€,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)