linux-kernel - Re: [PATCH v6] ASoC: dt-bindings: Add tas2781 DT documenting that binding along with the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f90e84b-1a9e-bc96-c9b3-12f95ea7bcff@linaro.org>
Date:   Fri, 24 Mar 2023 12:48:43 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shenghao Ding <13916275206@....com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, broonie@...nel.org,
        lgirdwood@...il.com
Cc:     kevin-lu@...com, shenghao-ding@...com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        x1077012@...com, peeyush@...com, navada@...com
Subject: Re: [PATCH v6] ASoC: dt-bindings: Add tas2781 DT documenting that
 binding along with the driver

On 24/03/2023 12:09, Shenghao Ding wrote:
> Create tas2781.yaml for tas2781 driver.
> 
> Signed-off-by: Shenghao Ding <13916275206@....com>

Where is the driver? Why are you sending these separate? You already got
comment about wrong threading, so I really expect some improvements.
> 
> ---
> Changes in v6:
>  - Remove all the "|" after "description:".
>  - Drop the reset-gpios description.
>  - Be consistent on the I2C.
>  Changes to be committed:
> 	new file:   Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> ---
>  .../devicetree/bindings/sound/ti,tas2781.yaml | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> new file mode 100644
> index 000000000000..af37595f3a6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAS2781 SmartAMP
> +
> +maintainers:
> +  - Shenghao Ding <shenghao-ding@...com>
> +  - Kevin Lu <kevin-lu@...com>
> +
> +description:
> +  The TAS2781 is a mono, digital input Class-D audio amplifier
> +  optimized for efficiently driving high peak power into small
> +  loudspeakers. Integrated an on-chip DSP supports Texas Instruments
> +  Smart Amp speaker protection algorithm. The integrated speaker
> +  voltage and current sense provides for real time
> +  monitoring of loudspeaker behavior.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tas2781
> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      I2C address of the primary device.

What happened here? Rob's comment seems ignored and now we have
description without anything useful.

> +
> +  reset-gpios:
> +    maxItems: 1
> +

Best regards,
Krzysztof