linux-kernel - Re: [PATCH v3 0/9] Update Intel events and make nvdimm events dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acb7dcae-6365-b2cb-6147-589376116df0@linux.intel.com>
Date:   Fri, 24 Mar 2023 08:11:44 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Edward Baker <edward.baker@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        perry.taylor@...el.com, caleb.biggers@...el.com,
        samantha.alt@...el.com, weilin.wang@...el.com
Subject: Re: [PATCH v3 0/9] Update Intel events and make nvdimm events dynamic



On 2023-03-24 3:22 a.m., Ian Rogers wrote:
> Update events from:
> https://github.com/intel/perfmon/pull/62
> 
> Add new #has_pmem literal to allow memory metrics to be dynamic in how
> nvdimm events are enabled. Update CLX, ICX and SPR for this using this
> PR:
> https://github.com/intel/perfmon/pull/63
> 
> v3. Change has_optane to has_pmem as suggested by Kan Liang and Dan Williams.
> 
> Ian Rogers (9):
>   perf vendor events: Broadwell v27 events
>   perf vendor events: Broadwellde v9 events
>   perf vendor events: Broadwellx v20 events
>   perf vendor events: Haswell v33 events
>   perf vendor events: Haswellx v27 events
>   perf vendor events: Jaketown v23 events
>   perf vendor events: Sandybridge v19 events
>   perf metrics: Add has_pmem literal
>   perf vendor events: Update metrics to detect pmem at runtime
> 


Thanks Ian. The patch series looks good to me.

Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks,
Kan

>  .../pmu-events/arch/x86/broadwell/cache.json  | 296 +++++-----
>  .../arch/x86/broadwell/floating-point.json    |   7 +
>  .../arch/x86/broadwell/frontend.json          |  18 +-
>  .../pmu-events/arch/x86/broadwell/memory.json | 248 ++++-----
>  .../arch/x86/broadwell/pipeline.json          |  22 +-
>  .../arch/x86/broadwell/uncore-other.json      |   2 +-
>  .../arch/x86/broadwellde/cache.json           | 105 ++--
>  .../arch/x86/broadwellde/floating-point.json  |  45 +-
>  .../arch/x86/broadwellde/frontend.json        |  18 +-
>  .../arch/x86/broadwellde/memory.json          |  64 ++-
>  .../arch/x86/broadwellde/pipeline.json        |  79 +--
>  .../arch/x86/broadwellde/uncore-cache.json    |  72 +--
>  .../arch/x86/broadwellde/uncore-memory.json   | 256 ++++++++-
>  .../arch/x86/broadwellde/uncore-other.json    |  27 +-
>  .../arch/x86/broadwellde/uncore-power.json    |  10 +-
>  .../pmu-events/arch/x86/broadwellx/cache.json |  16 +-
>  .../arch/x86/broadwellx/frontend.json         |  18 +-
>  .../arch/x86/broadwellx/pipeline.json         |  20 +-
>  .../arch/x86/broadwellx/uncore-cache.json     | 156 ++----
>  .../x86/broadwellx/uncore-interconnect.json   |  84 +--
>  .../arch/x86/broadwellx/uncore-memory.json    | 522 +++++++++---------
>  .../arch/x86/broadwellx/uncore-other.json     |  44 +-
>  .../arch/x86/broadwellx/uncore-power.json     |  10 +-
>  .../arch/x86/cascadelakex/clx-metrics.json    |  10 +-
>  .../pmu-events/arch/x86/haswell/cache.json    |  38 +-
>  .../pmu-events/arch/x86/haswell/memory.json   |  38 +-
>  .../pmu-events/arch/x86/haswell/pipeline.json |   8 +
>  .../pmu-events/arch/x86/haswellx/cache.json   |   2 +-
>  .../arch/x86/haswellx/pipeline.json           |   8 +
>  .../arch/x86/haswellx/uncore-cache.json       |  16 +-
>  .../arch/x86/haswellx/uncore-other.json       |   6 +-
>  .../arch/x86/icelakex/icx-metrics.json        |  10 +-
>  .../arch/x86/jaketown/pipeline.json           |   8 +
>  tools/perf/pmu-events/arch/x86/mapfile.csv    |  14 +-
>  .../arch/x86/sandybridge/pipeline.json        |   8 +
>  .../arch/x86/sapphirerapids/spr-metrics.json  |  10 +-
>  tools/perf/util/expr.c                        |  19 +
>  37 files changed, 1323 insertions(+), 1011 deletions(-)
>