[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8e593a61-8a0e-8e13-603b-ced514b7533e@amd.com>
Date: Fri, 24 Mar 2023 08:12:01 -0500
From: Terry Bowman <Terry.Bowman@....com>
To: kernel test robot <lkp@...el.com>, alison.schofield@...el.com,
vishal.l.verma@...el.com, ira.weiny@...el.com, bwidawsk@...nel.org,
dan.j.williams@...el.com, dave.jiang@...el.com,
Jonathan.Cameron@...wei.com, linux-cxl@...r.kernel.org,
rrichter@....com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
bhelgaas@...gle.com
Subject: Re: [PATCH v2 1/5] cxl/pci: Add RCH downstream port AER and RAS
register discovery
On 3/24/23 03:53, kernel test robot wrote:
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303241632.HTxJ0yfj-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>>> drivers/cxl/core/regs.c:340:24: sparse: sparse: Using plain integer as NULL pointer
> drivers/cxl/core/regs.c:345:24: sparse: sparse: Using plain integer as NULL pointer
>
> vim +340 drivers/cxl/core/regs.c
>
> 338
> 339 if (!request_mem_region(map->resource, map->max_size, name))
> > 340 return 0;
> 341
> 342 map->base = ioremap(map->resource, map->max_size);
> 343 if (!map->base) {
> 344 release_mem_region(map->resource, map->max_size);
> 345 return 0;
> 346 }
> 347
> 348 return map->base;
> 349 }
> 350
>
Yes, I will change the 0 return value to use NULL instead.
Regards,
Terry
Powered by blists - more mailing lists