linux-kernel - Re: [PATCH 1/6] driver core: device.h: remove extern from function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gPL9Zk65tXvc7hxySNdJgCj-si84mBq0iiHTHv7dmuXA@mail.gmail.com>
Date:   Fri, 24 Mar 2023 14:35:12 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 1/6] driver core: device.h: remove extern from function prototypes

On Fri, Mar 24, 2023 at 1:27 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> The kernel coding style does not require 'extern' in function prototypes
> in .h files, so remove them from include/linux/device.h as they are not
> needed.
>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

for this one and the rest of the series.

> ---
>  include/linux/device.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 3b23772d3bbb..472dd24d4823 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1088,8 +1088,7 @@ void device_link_remove(void *consumer, struct device *supplier);
>  void device_links_supplier_sync_state_pause(void);
>  void device_links_supplier_sync_state_resume(void);
>
> -extern __printf(3, 4)
> -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
> +__printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
>
>  /* Create alias, so I can be autoloaded. */
>  #define MODULE_ALIAS_CHARDEV(major,minor) \
> --
> 2.40.0
>