linux-kernel - Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID read fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WXeVYj2jRHLjD2wWCimb-wA+5QX-UaDhz9NogLGTTARw@mail.gmail.com>
Date:   Fri, 24 Mar 2023 07:00:15 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Pin-yen Lin <treapking@...omium.org>
Cc:     Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID
 read fail

Hi,

On Thu, Mar 23, 2023 at 8:59 PM Pin-yen Lin <treapking@...omium.org> wrote:
>
> drm_edid_read returns NULL on error, so feeding it directly into
> drm_edid_duplicate may lead to NULL pointer dereference. Add a check to
> guard this.
>
> Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID")
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> ---
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Given that the other patch just landed and this is a straightforward
fix, I'm not doing the customary "delay" before landing and I've
pushed this to drm-misc-next:

14aed8ea48e2 drm/bridge: ps8640: Return NULL immediately when EDID read fail

If someone else had extra feedback on this it could always be handled
in a followon patch.

-Doug