linux-kernel - Re: [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <addce339-7653-405b-8d1d-ef29da74a8f3@kili.mountain>
Date:   Sat, 25 Mar 2023 10:27:52 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Dalvin-Ehinoma Noah Aiguobas <pharcodra@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses

The subject has an extra : after the "[PATCH]:".

On Sat, Mar 25, 2023 at 01:22:25AM +0100, Dalvin-Ehinoma Noah Aiguobas wrote:
> Clean up Checkpatch issues by removing unnecessary Parentheses.
> 

Just ignore checkpatch on this.  Greg likes parentheses.

> @@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>  
>  			result = prism2_domibset_uint32(wlandev,
>  							DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> -				sme->key_idx);
> +							sme->key_idx);

Don't mix unrelated changes into the patch.

regards,
dan carpenter