linux-kernel - Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6da91d8c-6694-9041-2f2f-72a8e95c7df2@linaro.org>
Date:   Sat, 25 Mar 2023 12:35:06 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tao Zhang <quic_taozha@...cinc.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...il.com>,
        Mike Leach <mike.leach@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Jinlong Mao <quic_jinlmao@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element
 size

On 24/03/2023 10:15, Tao Zhang wrote:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    minimum: 32
>>>> +    maximum: 64
>>>
>>> Shouldn't this be something like oneOf ? It is not a range, but one of
>>> those two specific values ?
>>
>> Yes, "qcom,dsb-element-size" should be an optional option required in 
>> TPDM
>>
>> devicetree. Other properties like "qcom,cmb-element-size", 
>> "qcom,tc-element-size"
>>
>> and etc. will be added in a later patch series.
>>
>> I will update this doc according to your advice in the next version of 
>> the patch.
>>
>> Tao
>>
> Correct my misunderstanding in the mail above.
> 
> You are right, DSB element size should be 32-bit or 64-bit. I will 
> update this in the next

Then 'enum', not 'oneOf'.

Best regards,
Krzysztof