linux-kernel - Re: [PATCH 3/3] staging: rtl8192u: remove code from comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZB7ni6yQdTvuhOIW@kroah.com>
Date:   Sat, 25 Mar 2023 13:22:35 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8192u: remove code from comments

On Sat, Mar 25, 2023 at 05:13:18PM +0500, Khadija Kamran wrote:
> Writing code in comments is generally not considered a good coding
> practice.
> Remove all the code comments from the file.

How about something like:
	Remove all of the commented out code lines as they are not being
	used and can be brought back in the future if they are ever
	needed again.

And the subject reads a bit odd too, how about:
	staging: rtl8192u: remove commented out code

> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  drivers/staging/rtl8192u/r8192U_dm.c | 127 +--------------------------
>  1 file changed, 2 insertions(+), 125 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index 885c5966342f..f210ede8b1c7 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -50,11 +50,9 @@ static	void	dm_init_bandwidth_autoswitch(struct net_device *dev);
>  static	void	dm_bandwidth_autoswitch(struct net_device *dev);
>  
>  /* DM --> TX power control */
> -/*static	void	dm_initialize_txpower_tracking(struct net_device *dev);*/
>  
>  static	void	dm_check_txpower_tracking(struct net_device *dev);
>  
> -/*static	void	dm_txpower_reset_recovery(struct net_device *dev);*/
>  

The extra blank lines can now go away as well, at the same time, right?

thanks,

greg k-h