linux-kernel - Re: [PATCH 1/3] staging: rtl8192u: reformat block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZB7pkWRn9093sBnZ@khadija-virtual-machine>
Date:   Sat, 25 Mar 2023 17:31:13 +0500
From:   Khadija Kamran <kamrankhadijadj@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8192u: reformat block comments

On Sat, Mar 25, 2023 at 01:23:15PM +0100, Greg KH wrote:
> On Sat, Mar 25, 2023 at 05:13:16PM +0500, Khadija Kamran wrote:
> > Linux kernel coding style for block comments uses a column of '*' on the
> > left side and  uses '*/' on a separate line.
> > 
> > Fix block comments by adding '*' on subsequent lines and moving '*/' at
> > the end of block comments on a separate line. These issues in block
> > comments are reported by checkpatch.pl script.
> > 
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> > ---
> >  drivers/staging/rtl8192u/r8192U_dm.c | 162 ++++++++++++++-------------
> >  1 file changed, 86 insertions(+), 76 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> > index 6a33ca02c3dc..a88686be3523 100644
> > --- a/drivers/staging/rtl8192u/r8192U_dm.c
> > +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> > @@ -1,19 +1,20 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*++
> > -Copyright-c Realtek Semiconductor Corp. All rights reserved.
> > -
> > -Module Name:
> > -	r8192U_dm.c
> > -
> > -Abstract:
> > -	HW dynamic mechanism.
> > -
> > -Major Change History:
> > -	When		Who				What
> > -	----------	--------------- -------------------------------
> > -	2008-05-14	amy                     create version 0 porting from windows code.
> > -
> > ---*/
> > + * Copyright-c Realtek Semiconductor Corp. All rights reserved.
> > + *
> > + * Module Name:
> > + *	r8192U_dm.c
> > + *
> > + * Abstract:
> > + *	HW dynamic mechanism.
> > + *
> > + * Major Change History:
> > + *	When		Who				What
> > + *	----------	--------------- -------------------------------
> > + *	2008-05-14	amy                     create version 0 porting from windows code.
> > + *
> > + *--
> > + */
> >  #include "r8192U.h"
> >  #include "r8192U_dm.h"
> >  #include "r8192U_hw.h"
> > @@ -147,20 +148,20 @@ void dm_CheckRxAggregation(struct net_device *dev)
> >  	unsigned long		curRxOkCnt = 0;
> >  
> >  /*
> > -	if (pHalData->bForcedUsbRxAggr) {
> > -		if (pHalData->ForcedUsbRxAggrInfo == 0) {
> > -			if (pHalData->bCurrentRxAggrEnable) {
> > -				Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, FALSE);
> > -			}
> > -		} else {
> > -			if (!pHalData->bCurrentRxAggrEnable || (pHalData->ForcedUsbRxAggrInfo != pHalData->LastUsbRxAggrInfoSetting)) {
> > -				Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, TRUE);
> > -			}
> > -		}
> > -		return;
> > -	}
> > -
> > -*/
> > + *	if (pHalData->bForcedUsbRxAggr) {
> > + *		if (pHalData->ForcedUsbRxAggrInfo == 0) {
> > + *			if (pHalData->bCurrentRxAggrEnable) {
> > + *				Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, FALSE);
> > + *			}
> > + *		} else {
> > + *			if (!pHalData->bCurrentRxAggrEnable || (pHalData->ForcedUsbRxAggrInfo != pHalData->LastUsbRxAggrInfoSetting)) {
> > + *				Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, TRUE);
> > + *			}
> > + *		}
> > + *		return;
> > + *	}
> > + *
> > + */
> 
> Do not reformat things, only to remove them in the last commit in the
> series.  Instead, remove the commented out code lines first, and then
> fix up any remaining ones, that should make the churn much less.

Hey Greg,

Thank you for the feedback. Let me resend the patchset after doing all
the advised changes.

Regards,
Khadija

> 
> thanks,
> 
> greg k-h