linux-kernel - Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Mar 2023 18:35:08 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Ye, Xiang" <xiang.ye@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Lee Jones <lee@...nel.org>, Wolfram Sang <wsa@...nel.org>,
        Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-usb@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-gpio@...r.kernel.org,
        srinivas.pandruvada@...el.com, heikki.krogerus@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, sakari.ailus@...ux.intel.com,
        zhifeng.wang@...el.com, wentong.wu@...el.com, lixu.zhang@...el.com
Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device

On Sun, Mar 26, 2023 at 01:26:55AM +0800, Ye, Xiang wrote:
> Hi Greg,
> 
> Thanks for the review.
> On Sat, Mar 25, 2023 at 05:20:09PM +0100, Greg Kroah-Hartman wrote:
> > On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote:
> > > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
> > > device named "La Jolla Cove Adapter" (LJCA).
> > > 
> > > The communication between the various LJCA module drivers and the
> > > hardware will be muxed/demuxed by this driver. Three modules (
> > > I2C, GPIO, and SPI) are supported currently.
> > > 
> > > Each sub-module of LJCA device is identified by type field within
> > > the LJCA message header.
> > > 
> > > The minimum code in ASL that covers this board is
> > 
> > As this requires ACPI, why are you not saying so in your Kconfig entry?
> I would add a `depends on ACPI` item on the Kconfig entry so that the
> CONFI_ACPI macro can be removed from usb-ljca, because our use case with
> LJCA currently needs the ACPI binding.

That would make more sense.

thanks,

greg k-h