[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230325191426.5810b644@jic23-huawei>
Date: Sat, 25 Mar 2023 19:14:26 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: James Clark <james.clark@....com>
Cc: linux-kernel@...r.kernel.org, linux@...ck-us.net,
michal.simek@....com, Jonathan.Cameron@...wei.com,
Jonathan Corbet <corbet@....net>,
Jean Delvare <jdelvare@...e.com>,
Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Michal Simek <michal.simek@...inx.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, linux-doc@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 4/4] serial: qcom_geni: Comment use of devm_krealloc
rather than devm_krealloc_array
On Mon, 20 Mar 2023 14:57:09 +0000
James Clark <james.clark@....com> wrote:
> Now that devm_krealloc_array is available, add a comment justifying not
> changing this occurrence to avoid any future auto fixups.
>
> Link: https://lore.kernel.org/all/20230318173402.20a4f60d@jic23-huawei/
> Signed-off-by: James Clark <james.clark@....com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 28fbc927a546..8ae1fb7c2636 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1055,6 +1055,11 @@ static int setup_fifos(struct qcom_geni_serial_port *port)
> (port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE;
>
> if (port->rx_buf && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> + /*
> + * Use krealloc rather than krealloc_array because rx_buf is
> + * accessed as 1 byte entries as well as 4 byte entries so it's
> + * not necessarily an array.
> + */
> port->rx_buf = devm_krealloc(uport->dev, port->rx_buf,
> port->rx_fifo_depth * sizeof(u32),
> GFP_KERNEL);
Powered by blists - more mailing lists