linux-kernel - Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Mar 2023 06:13:16 -0700
From:   Tom Rix <trix@...hat.com>
To:     Greg KH <gregkh@...uxfoundation.org>, Nam Cao <namcaov@...il.com>
Cc:     nathan@...nel.org, ndesaulniers@...gle.com,
        artur.bujdoso@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable


On 3/26/23 5:55 AM, Greg KH wrote:
> On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
>> On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
>>> clang with W=1 reports
>>> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>>>    'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>>>          struct hal_com_data *pHalData;
>>>                               ^
>>> This variable is not used so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@...hat.com>
>>> ---
>>>   drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> index e36f8c369a04..0cb2adcc1f78 100644
>>> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>>>   
>>>   void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>>>   {
>>> -	struct hal_com_data *pHalData;
>>> -
>>> -
>>> -	pHalData = GET_HAL_DATA(padapter);
>>>   }
>> If this function doesn't do anything, does it not make more sense to
>> just remove this function entirely?
> This function is already removed in linux-next, so it doesn't matter :)

My patch is against linux-next from tag next-20230324

Tom

>
> thanks,
>
> greg k-h
>