[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55ddb6da555a408da801f56577845a09@AcuMS.aculab.com>
Date: Sun, 26 Mar 2023 13:37:37 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
Kees Cook <keescook@...omium.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Cezary Rojewski <cezary.rojewski@...el.com>,
"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.com>,
Andy Shevchenko <andy@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>
Subject: RE: [PATCH v2 3/3] kobject: Use return value of strreplace()
From: Andy Shevchenko
> Sent: 23 March 2023 12:37
>
> Since strreplace() returns the pointer to the string itself,
> we may use it directly in the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> lib/kobject.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index f79a434e1231..16d530f9c174 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -281,8 +281,7 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> kfree_const(s);
> if (!t)
> return -ENOMEM;
> - strreplace(t, '/', '!');
> - s = t;
> + s = strreplace(t, '/', '!');
Why do this? It just makes the code harder to read because
you have to know another 'silly fact' about a function.
Possibly useful return values might be:
1) The address of the first changed character.
2) The address of the last changed characher.
3) The '\0' terminator.
4) void.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Powered by blists - more mailing lists