linux-kernel - Re: [PATCH v2] crypto - img-hash: Depend on OF and silence compile test warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZB+zopc6ieXoqFcE@gondor.apana.org.au>
Date:   Sun, 26 Mar 2023 10:53:22 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2] crypto - img-hash: Depend on OF and silence compile
 test warning

On Sat, Mar 25, 2023 at 12:01:47PM +0100, Krzysztof Kozlowski wrote:
>
> In that case yes, but we want COMPILE_TEST for build coverage.

No we don't.  Selecting OF is trivial and even the bots will
cover this.  We have lots of drivers under crypto that depend
on COMPILE_TEST as well as OF.

> > Anyway, I think adding __maybe_unused by itself is sufficient.

If you really want to patch this driver then adding maybe_unused
is the way to go.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt