linux-kernel - Re: [PATCH] rcu: torture: ppc: Remove duplicated argument --enable-kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7286a0ab-c8a3-407f-b242-7e823fc39814@paulmck-laptop>
Date:   Sun, 26 Mar 2023 08:08:56 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     zhouzhouyi@...il.com
Cc:     rcu@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, lance@...osl.org
Subject: Re: [PATCH] rcu: torture: ppc: Remove duplicated argument
 --enable-kvm

On Sun, Mar 26, 2023 at 08:24:34AM +0800, zhouzhouyi@...il.com wrote:
> From: Zhouyi Zhou <zhouzhouyi@...il.com>
> 
> The argument --enable-kvm is duplicated because qemu_args
> in kvm-test-1-run.sh has already give this.
>           
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>

Good catch!  Applied, thank you!

							Thanx, Paul

> ---
> Dear RCU and PPC developers
> 
> I discover this possible minor flaw when I am performing RCU torture
> test in PPC VM of of Open Source Lab of Oregon State University.
> 
> But I can't test my patch because I am in a VM.
> 
> Thanks for your time
> 
> Cheers ;-)
> Zhouyi                                           
> --    
>  tools/testing/selftests/rcutorture/bin/functions.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/rcutorture/bin/functions.sh b/tools/testing/selftests/rcutorture/bin/functions.sh
> index b52d5069563c..48b9147e8c91 100644
> --- a/tools/testing/selftests/rcutorture/bin/functions.sh
> +++ b/tools/testing/selftests/rcutorture/bin/functions.sh
> @@ -250,7 +250,7 @@ identify_qemu_args () {
>  		echo -machine virt,gic-version=host -cpu host
>  		;;
>  	qemu-system-ppc64)
> -		echo -enable-kvm -M pseries -nodefaults
> +		echo -M pseries -nodefaults
>  		echo -device spapr-vscsi
>  		if test -n "$TORTURE_QEMU_INTERACTIVE" -a -n "$TORTURE_QEMU_MAC"
>  		then
> -- 
> 2.34.1
>