linux-kernel - Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03ec1aac-3c6d-892f-fad9-f386a5d4d10e@linaro.org>
Date:   Sun, 26 Mar 2023 22:02:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shane Francis <bigbeeshane@...il.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        heiko@...ech.de, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions

On 26/03/2023 19:51, Shane Francis wrote:
>> Bootloader also does not use mainline DTS, so where is exactly the problem?
> 
> In this case uboot does load the target DTB, and it seems a common
> function in rockchips
> downstream boot process, see :
> 
> https://github.com/rockchip-linux/u-boot/blob/ef1dd650042f61915c4859ecc94623a09a3529fa/arch/arm/mach-rockchip/kernel_dtb.c#L70
> 

U-Boot comes with its own DTB, so what does it means "loads the target
DTB"? From where? The one appended to the kernel zImage? No, it cannot...

Any component which operates on mainline DTB must conform to the
bindings (with respect to the ABI), thus your arguments here mean you
are not allowed to change ABI in the future. Never. This change,
assuming original binding was broken, could be warranted.


Best regards,
Krzysztof