linux-kernel - Re: [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ac7e3d7-c96a-26dc-17ef-3ce5d6bc03db@nvidia.com>
Date:   Sun, 26 Mar 2023 23:05:35 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Juraj Pecigos <kernel@...aj.dev>, Christoph Hellwig <hch@....de>
CC:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN

On 3/26/23 02:29, Juraj Pecigos wrote:
> A system with more than one of these SSDs will only have one usable.
> The kernel fails to detect more than one nvme device due to duplicate
> cntlids.
>
> before:
> [    9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    9.395262] nvme nvme0: pci function 0000:01:00.0
> [    9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    9.395305] nvme nvme1: pci function 0000:03:00.0
> [    9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn-                    , rejecting
> [    9.409982] nvme nvme0: Removing after probe failure status: -22
> [    9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
> [    9.445088] nvme nvme1: 16/0/0 default/read/poll queues
> [    9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> after:
> [    1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    1.162660] nvme nvme0: pci function 0000:01:00.0
> [    1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    1.162707] nvme nvme1: pci function 0000:03:00.0
> [    1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
> [    1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
> [    1.211044] nvme nvme1: 16/0/0 default/read/poll queues
> [    1.211080] nvme nvme0: 16/0/0 default/read/poll queues
> [    1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
> [    1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.
>
> Signed-off-by: Juraj Pecigos <kernel@...aj.dev>
> ---
>

Just looking at the log in the commit message seems like
this is solving your problem, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck