linux-kernel - Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABnpCuC1PLYT82A2iMPkPgRPB0mzGUfF=wBzPpAp+YMN_VfGjg@mail.gmail.com>
Date:   Mon, 27 Mar 2023 00:31:18 +0100
From:   Shane Francis <bigbeeshane@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        heiko@...ech.de, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions

Hi

> We did not finish discussion yet, so sending new version 50 minutes
> after your last reply does not give me a chance to respond.

I was refreshing the patch set to address your comments on the new DTS
setup for the R6S, I did not change this portion of the patch.

I apologise for missing some of the rules here, I am just onboarding this
device for a personal project, but will leave it here for now.


Regards


On Sun, Mar 26, 2023 at 9:04 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 26/03/2023 20:40, Shane Francis wrote:
> > Some vendor uboot bootloaders use the target kernels DTB image to
> > determine the target clock speeds for some PLLs, currently this can cause
> > uboot to set the clock rate for gpll incorrectly on to cpll (breaking)
> > RGMII.
>
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets.
>
> >
> > This change starts the PLL clock definitions from 1 to correct this
> > miss-match
> >
> > This could be handled by uboot bu updating mappings in that code base
> > however not all devices will have a replaceable uboot (in cases such as
> > when a secure boot chain is implemented)
> >
> > Signed-off-by: Shane Francis <bigbeeshane@...il.com>
> > ---
> >  .../dt-bindings/clock/rockchip,rk3588-cru.h   | 1442 ++++++++---------
> >  1 file changed, 721 insertions(+), 721 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > index b5616bca7b44..d63b07d054b7 100644
> > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>
> We did not finish discussion yet, so sending new version 50 minutes
> after your last reply does not give me chance to respond.
>
> Best regards,
> Krzysztof
>