linux-kernel - Re: [PATCH] qed: remove unused num_ooo_add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZB/6C7xCSqTEYvry@corigine.com>
Date:   Sun, 26 Mar 2023 09:53:47 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Tom Rix <trix@...hat.com>
Cc:     aelior@...vell.com, manishc@...vell.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        nathan@...nel.org, ndesaulniers@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable

On Sat, Mar 25, 2023 at 08:17:33PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
>   'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
>         u32 num_ooo_add_to_peninsula = 0, cid;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>