linux-kernel - Re: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eea970cd-d781-9d4c-e020-9086505a4ba7@deltatee.com>
Date:   Mon, 27 Mar 2023 09:48:08 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()



On 2023-03-27 01:36, Cai Huoqing wrote:
> Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
> because pci_p2pmem_dma() is already removed.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>

Thanks for noticing this!

> ---
>  drivers/pci/p2pdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..4f1798ecf38f 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>  /**
>   * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
>   *	the specified list of clients and shortest distance (as determined
> - *	by pci_p2pmem_dma())
> + *	by pci_p2pdma_map_segment())

Maybe we should just remove the reference to pci_p2pdma_map_segment()
completely. I don't see how that function helps the reader any more and
is really different section of the API anyway.

Logan