linux-kernel - Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 12:31:13 -0500
From:   Steev Klimaszewski <steev@...i.org>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers

On Mon, Mar 27, 2023 at 7:30 AM Johan Hovold <johan+linaro@...nel.org> wrote:
>
> The pmk8280 PMIC PON peripheral is gen3 and uses two sets of registers;
> hlos and pbs.
>
> This specifically fixes the following error message during boot when the
> pbs registers are not defined:
>
>         PON_PBS address missing, can't read HW debounce time
>
> Note that this also enables the spurious interrupt workaround introduced
> by commit 0b65118e6ba3 ("Input: pm8941-pwrkey - add software key press
> debouncing support") (which may or may not be needed).
>
> Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device")
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> index c35e7f6bd657..a0ba535bb6c9 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> @@ -59,8 +59,9 @@ pmk8280: pmic@0 {
>                 #size-cells = <0>;
>
>                 pmk8280_pon: pon@...0 {
> -                       compatible = "qcom,pm8998-pon";
> -                       reg = <0x1300>;
> +                       compatible = "qcom,pmk8350-pon";
> +                       reg = <0x1300>, <0x800>;
> +                       reg-names = "hlos", "pbs";
>
>                         pmk8280_pon_pwrkey: pwrkey {
>                                 compatible = "qcom,pmk8350-pwrkey";
> --
> 2.39.2
>
Tested on the Thinkpad X13s

Tested-by: Steev Klimaszewski <steev@...i.org> #Thinkpad X13s