linux-kernel - [PATCH 10/12] drm/amd/display: Remove unused variable 'cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230327233353.64081-11-caionovais@usp.br>
Date:   Mon, 27 Mar 2023 20:33:51 -0300
From:   Caio Novais <caionovais@....br>
To:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Jack Xiao <Jack.Xiao@....com>,
        Hawking Zhang <Hawking.Zhang@....com>, Le Ma <le.ma@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        Yifan Zhang <yifan1.zhang@....com>,
        Mukul Joshi <mukul.joshi@....com>, Jun Lei <Jun.Lei@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Alan Liu <HaoPing.Liu@....com>,
        Caio Novais <caionovais@....br>,
        Joshua Ashton <joshua@...ggi.es>,
        Guo Zhengkui <guozhengkui@...o.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Zhan Liu <zhan.liu@....com>, Wayne Lin <wayne.lin@....com>,
        Charlene Liu <Charlene.Liu@....com>,
        Martin Leung <Martin.Leung@....com>,
        Tom Chung <chiahsuan.chung@....com>,
        Alvin Lee <alvin.lee2@....com>,
        George Shen <George.Shen@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Roman Li <Roman.Li@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Jingwen Zhu <Jingwen.Zhu@....com>,
        Melissa Wen <mwen@...lia.com>,
        Felipe Clark <felipe.clark@....com>,
        Sung Joon Kim <sungjoon.kim@....com>,
        Dillon Varone <Dillon.Varone@....com>,
        Ethan Wellenreiter <Ethan.Wellenreiter@....com>,
        Taimur Hassan <Syed.Hassan@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Brian Chang <Brian.Chang@....com>,
        Gabe Teeger <gabe.teeger@....com>,
        André Almeida <andrealmeid@...lia.com>,
        Chaitanya Dhere <chaitanya.dhere@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Ryan Lin <tsung-hua.lin@....com>,
        Hamza Mahfooz <hamza.mahfooz@....com>
Subject: [PATCH 10/12] drm/amd/display: Remove unused variable 'cursor_bpp'

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c: In function ‘dcn32_helper_calculate_mall_bytes_for_cursor’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:62:18: warning: variable ‘cursor_bpp’ set but not used [-Wunused-but-set-variable]

Get rid of it by removing the variable.

Signed-off-by: Caio Novais <caionovais@....br>
---
 drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c
index 3a2d7bcc4b6d..a616cf078cf4 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c
@@ -59,25 +59,21 @@ uint32_t dcn32_helper_calculate_mall_bytes_for_cursor(
 {
 	struct hubp *hubp = pipe_ctx->plane_res.hubp;
 	uint32_t cursor_size = hubp->curs_attr.pitch * hubp->curs_attr.height;
-	uint32_t cursor_bpp = 4;
 	uint32_t cursor_mall_size_bytes = 0;
 
 	switch (pipe_ctx->stream->cursor_attributes.color_format) {
 	case CURSOR_MODE_MONO:
 		cursor_size /= 2;
-		cursor_bpp = 4;
 		break;
 	case CURSOR_MODE_COLOR_1BIT_AND:
 	case CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA:
 	case CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA:
 		cursor_size *= 4;
-		cursor_bpp = 4;
 		break;
 
 	case CURSOR_MODE_COLOR_64BIT_FP_PRE_MULTIPLIED:
 	case CURSOR_MODE_COLOR_64BIT_FP_UN_PRE_MULTIPLIED:
 		cursor_size *= 8;
-		cursor_bpp = 8;
 		break;
 	}
 
-- 
2.40.0