linux-kernel - Re: [PATCH -next v6 2/2] mm/zswap: delay the initializaton of zswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM4kBBKdz4oSXpACw=ntwSUi4yH7H65Bu4T+5-NSFtqmUp6SoQ@mail.gmail.com>
Date:   Mon, 27 Mar 2023 08:19:56 +0200
From:   Vitaly Wool <vitaly.wool@...sulko.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Liu Shixin <liushixin2@...wei.com>,
        Seth Jennings <sjenning@...hat.com>,
        Dan Streetman <ddstreet@...e.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH -next v6 2/2] mm/zswap: delay the initializaton of zswap

On Thu, Mar 23, 2023 at 8:59 AM Christoph Hellwig <hch@....de> wrote:
>
> On Wed, Mar 22, 2023 at 06:17:12PM +0100, Vitaly Wool wrote:
> > On Wed, Mar 22, 2023 at 10:30 AM Liu Shixin <liushixin2@...wei.com> wrote:
> > >
> > > Since some users may not use zswap, the zswap_pool is wasted. Save memory
> > > by delaying the initialization of zswap until enabled.
> >
> > To be honest, I'm not a huge fan of this. Would enabling zswap module
> > build instead solve your problem?
>
> making zswap build modular would be a mess.  It is core MM infrastructure
> and now we'd need to start dealing with adding and removing it at
> runtime as well as module refcounting.

Since when is it a core MM infrastructure? It is basically just a
frontswap frontend.

~Vitaly