linux-kernel - Re: [PATCH -next 1/2] spi: sprd-adi: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 14:46:12 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, broonie@...nel.org
Cc:     orsonzhai@...il.com, zhang.lyra@...il.com,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] spi: sprd-adi: Use
 devm_platform_get_and_ioremap_resource()



On 3/27/2023 2:05 PM, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/spi/spi-sprd-adi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c
> index 3b158124d79f..22e39c4c12c4 100644
> --- a/drivers/spi/spi-sprd-adi.c
> +++ b/drivers/spi/spi-sprd-adi.c
> @@ -541,8 +541,7 @@ static int sprd_adi_probe(struct platform_device *pdev)
>   	dev_set_drvdata(&pdev->dev, ctlr);
>   	sadi = spi_controller_get_devdata(ctlr);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sadi->base = devm_ioremap_resource(&pdev->dev, res);
> +	sadi->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(sadi->base)) {
>   		ret = PTR_ERR(sadi->base);
>   		goto put_ctlr;