linux-kernel - Re: [RESEND PATCH v7 0/5] can: bxcan: add support for ST bxCAN controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230327075106.ucfzckbhkwa23wci@pengutronix.de>
Date:   Mon, 27 Mar 2023 09:51:06 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Rob Herring <robh+dt@...nel.org>,
        Amarula patchwork <linux-amarula@...rulasolutions.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        michael@...rulasolutions.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-can@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com, netdev@...r.kernel.org
Subject: Re: [RESEND PATCH v7 0/5] can: bxcan: add support for ST bxCAN
 controller

On 26.03.2023 18:07:14, Dario Binacchi wrote:
> > On 21.03.2023 12:25:15, Dario Binacchi wrote:
> > > A gentle ping to remind you of this series.
> > > I have no idea why it hasn't deserved any response for quite some
> > > time.
> > > Is there anything I am still missing?
> >
> > I wonder if we want to do a s/master/primary/ in the DT bindings and
> > driver?
> 
> The ST reference manual (RM0386) explicitly uses the master and slave words
> in the bxcan chapter.

ACK

> I would stay consistent with it.

Yes, this is a known problem, on the one hand I'd like the drivers to
match the datasheet, but here I am in favor of a deviation.

> But I have no problem changing it to primary. I just sent v8 with the
> changes you suggested for shared irq and clock enable/disable,

These changes look good!

> but if you prefer to use primary I will send the v9 version with that
> change. Please let me know your opinion.

Please convert the driver and bindings to use "primary". Feel free to
mention that the datasheet calls the primary peripheral "master".

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung Nürnberg              | Phone: +49-5121-206917-129  |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)