linux-kernel - Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecd3a92b-ba1e-e7c1-088a-371bd1a2c100@linux-m68k.org>
Date:   Mon, 27 Mar 2023 18:07:41 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     peng.fan@....com, laurent.pinchart@...asonboard.com,
        krzysztof.kozlowski+dt@...aro.org, festevam@...il.com,
        abelvesa@...nel.org, marex@...x.de, Markus.Niebel@...tq-group.com,
        paul.elder@...asonboard.com, gerg@...nel.org, linux-imx@....com,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        s.hauer@...gutronix.de, robh+dt@...nel.org, aford173@...il.com,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        djakov@...nel.org, l.stach@...gutronix.de, shawnguo@...nel.org,
        abailon@...libre.com,
        Alexander Stein <alexander.stein@...tq-group.com>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk
 ctrl

Hi Ahmad,

On 27/3/23 17:16, Ahmad Fatoum wrote:
> On 27.03.23 08:27, Alexander Stein wrote:
>> Am Montag, 27. März 2023, 06:50:37 CEST schrieb Greg Ungerer:
>>> Any thoughts on why this breaks USB?
>>
>> Maybe you are missing CONFIG_INTERCONNECT_IMX8MP?
> 
> And if that's the case, did you check /sys/kernel/debug/devices_deferred
> to see if there was any indication that this is the reason?

Yeah, it does:

     # cat /sys/kernel/debug/devices_deferred
     32f10100.usb	platform: supplier 32f10000.blk-ctrl not ready
     32f10108.usb	platform: supplier 32f10000.blk-ctrl not ready
     32ec0000.blk-ctrl	imx8m-blk-ctrl: failed to get noc entries
     381f0040.usb-phy	platform: supplier 32f10000.blk-ctrl not ready
     382f0040.usb-phy	platform: supplier 32f10000.blk-ctrl not ready
     imx-pgc-domain.11	
     imx-pgc-domain.12	
     imx-pgc-domain.13	
     38330000.blk-ctrl	platform: supplier imx-pgc-domain.11 not ready
     32f10000.blk-ctrl	imx8mp-blk-ctrl: failed to get noc entries

As far as I can tell blk-ctrl should be good:

     #
     # i.MX SoC drivers
     #
     CONFIG_IMX_GPCV2_PM_DOMAINS=y
     CONFIG_SOC_IMX8M=y
     # CONFIG_SOC_IMX9 is not set
     CONFIG_IMX8M_BLK_CTRL=y
     # end of i.MX SoC drivers


> If you didn't find any hint there, you might want to place a
> dev_err_probe with a suitable message at the place where -EPROBE_DEFER
> was returned.

I will try that.

Thanks
Greg