linux-kernel - Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edpatxrr.fsf@minerva.mail-host-address-is-not-set>
Date:   Mon, 27 Mar 2023 10:16:08 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Jarrah <kernel@...ef.tools>, linux-kernel@...r.kernel.org
Cc:     Robert Mader <robert.mader@...labora.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Peter Robinson <pbrobinson@...il.com>,
        Jacopo Mondi <jacopo.mondi@...asonboard.com>,
        Ondrej Jirman <megi@....cz>, Martijn Braam <martijn@...xit.nl>,
        Kamil Trzciński <ayufan@...fan.eu>,
        Caleb Connolly <kc@...tmarketos.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tom Fitzhenry <tom@...-fitzhenry.me.uk>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal
 display support

Jarrah <kernel@...ef.tools> writes:

> Hi Javier,
>
> On 3/27/23 18:41, Javier Martinez Canillas wrote:
>> From: Ondrej Jirman <megi@....cz>
>>
>> The phone's display is using a Hannstar LCD panel. Support it by adding a
>> panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
>>
>> Signed-off-by: Ondrej Jirman <megi@....cz>
>> Co-developed-by: Martijn Braam <martijn@...xit.nl>
>> Co-developed-by: Kamil Trzciński <ayufan@...fan.eu>
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> ---
>>
>> Changes in v2:
>> - Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
>
>
> Any reason not to include this with the correct compatible string? It's 
> been available since 
> https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/. 
> Swapping out gt917s for gt1158 in the node from your previous patch 
> should be enough.
>

Yes, but I didn't know that the driver already had the compatible string
so I just dropped it for now and was meaning to take a look to that later.

Adding the touchscreen node can be done as a follow-up though in another
patch.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat