linux-kernel - Re: [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230327015334.GB3364759@dragon>
Date:   Mon, 27 Mar 2023 09:53:34 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Peng Fan <peng.fan@....com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields

On Mon, Mar 13, 2023 at 08:49:03AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> The clang-analyzer reports:
> "Excessive padding in 'struct imx8m_blk_ctrl_domain_data'
> (12 padding bytes, where 4 is optimal). Optimal fields order: name,
> clk_names, path_names, gpc_name, num_clks, num_paths, rst_mask, clk_mask,
> mipi_phy_rst_mask, consider reordering the fields or adding explicit
> padding members [clang-analyzer-optin.performance.Padding]
>    struct imx8m_blk_ctrl_domain_data {"
> 
> So reordering the fields.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Peng Fan <peng.fan@....com>

Applied, thanks!