linux-kernel - Re: [PATCH -next 1/3] spi: omap2-mcspi: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12626f35-6b7c-bb24-606a-00d0b8e7f375@ti.com>
Date:   Mon, 27 Mar 2023 13:56:52 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <broonie@...nel.org>
CC:     <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next 1/3] spi: omap2-mcspi: Use
 devm_platform_get_and_ioremap_resource()

On 27/03/23 11:23, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
For the series,

Reviewed-by: Dhruva Gole <d-gole@...com>

>  drivers/spi/spi-omap2-mcspi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index d95f0ae033ca..8331e247bf5c 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -1477,8 +1477,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
>  		master->max_transfer_size = omap2_mcspi_max_xfer_size;
>  	}
>  
> -	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	mcspi->base = devm_ioremap_resource(&pdev->dev, r);
> +	mcspi->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
>  	if (IS_ERR(mcspi->base)) {
>  		status = PTR_ERR(mcspi->base);
>  		goto free_master;

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated