linux-kernel - Re: [PATCH 2/2] xen/netback: remove not needed test in xenvif_tx_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <990111ae-d2ba-5bfc-457d-bacb2b6ffb43@xen.org>
Date:   Mon, 27 Mar 2023 10:04:33 +0100
From:   Paul Durrant <xadimgnik@...il.com>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        xen-devel@...ts.xenproject.org, Jan Beulich <jbeulich@...e.com>
Subject: Re: [PATCH 2/2] xen/netback: remove not needed test in
 xenvif_tx_build_gops()

On 27/03/2023 09:36, Juergen Gross wrote:
> The tests for the number of grant mapping or copy operations reaching
> the array size of the operations buffer at the end of the main loop in
> xenvif_tx_build_gops() isn't needed.
> 
> The loop can handle at maximum MAX_PENDING_REQS transfer requests, as
> XEN_RING_NR_UNCONSUMED_REQUESTS() is taking unsent responses into
> consideration, too.
> 
> Remove the tests.
> 
> Suggested-by: Jan Beulich <jbeulich@...e.com>
> Signed-off-by: Juergen Gross <jgross@...e.com>
> ---
>   drivers/net/xen-netback/netback.c | 4 ----
>   1 file changed, 4 deletions(-)
> 

Reviewed-by: Paul Durrant <paul@....org>